allow float as weight in afni's Allineate #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salma1601
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
+ Coverage 72.27% 72.28% +<.01%
==========================================
Files 1175 1175
Lines 58778 58779 +1
Branches 8460 8460
==========================================
+ Hits 42483 42486 +3
+ Misses 14933 14931 -2
Partials 1362 1362
Continue to review full report at Codecov.
|
oesteban
reviewed
Oct 4, 2017
nipype/interfaces/afni/preprocess.py
Outdated
| @@ -353,12 +353,13 @@ class AllineateInputSpec(AFNICommandInputSpec): | |||
| argstr='-nomask', | |||
| desc='Don\'t compute the autoweight/mask; if -weight is not ' | |||
| 'also used, then every voxel will be counted equally.') | |||
| weight_file = File( | |||
There was a problem hiding this comment.
AFNI Allineate has been there for a long while. Would it make sense to leave the weight_file input here with the deprecated meta set?
weight_file = File(
argstr='-weight %s',
exists=True,
deprecated='1.0.0', new_name='weight',
desc='Set the weighting for each voxel in the base dataset; '
'larger weights mean that voxel count more in the cost function. '
'Must be defined on the same grid as the base dataset')There was a problem hiding this comment.
Would it make sense to leave the weight_file input here with the deprecated meta set?
Ok, sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFNI's
3dAllineateaccepts either float or dataset as weight